Skip to content

fix: use only php min and max in linter#657

Merged
SebastianKrupinski merged 1 commit intomasterfrom
fix/linter-use-only-php-min-max
Mar 6, 2026
Merged

fix: use only php min and max in linter#657
SebastianKrupinski merged 1 commit intomasterfrom
fix/linter-use-only-php-min-max

Conversation

@SebastianKrupinski
Copy link
Contributor

Summary

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski self-assigned this Jan 15, 2026
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Jan 15, 2026
@nickvergessen
Copy link
Member

Instead we will switch linting to take 1-2 seconds, then this is not worth it anymore:
nextcloud/3rdparty#2259

I'm not aware there was ever a linting issue on a middle version, but not worth it from my POV

@SebastianKrupinski
Copy link
Contributor Author

Instead we will switch linting to take 1-2 seconds, then this is not worth it anymore: nextcloud/3rdparty#2259

I'm not aware there was ever a linting issue on a middle version, but not worth it from my POV

I made the improvement in the calendar application to reduce the amount of jobs that need to run, one to the team members recommended I share the change so that other apps can adopt it.

If this not worth it we can close the PR

@SebastianKrupinski
Copy link
Contributor Author

Instead we will switch linting to take 1-2 seconds, then this is not worth it anymore: nextcloud/3rdparty#2259

I'm not aware there was ever a linting issue on a middle version, but not worth it from my POV

Actually disregard we can close this... I think it is still valid... It still takes time, processing power and bandwith to setup a runner, download the images and run the tests... so I think this is still valid change

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this, we should only schedule CI jobs we really need.

@SebastianKrupinski SebastianKrupinski merged commit c93a7ae into master Mar 6, 2026
5 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/linter-use-only-php-min-max branch March 6, 2026 13:51
@nickvergessen
Copy link
Member

This is really the wrong seconds saved, but sure.
Any effort reducing failure rate in server is better spend, then cutting of something that takes literally 1 second of actual work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants